[ServiceWorker] Reject update() from within installing workers #16983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 23, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1626600
branch
3 times, most recently
from
937815e
to
80b0211
Compare
The service worker spec mandates that update() fails immediately if called from within service workers that are currently installing (i.e. if update() is called in the |install|-event-handler). This change implements this behavior and updates the WPT to match the spec. Bug: 895845 Change-Id: Ie07563e5ac8260554ef0947be4cb020124cfeddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626600 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#663695}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1626600
branch
from
80b0211
to
308c997
Compare
|
The flakiness is pre-existing:
I'm force-merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service worker spec mandates that update() fails immediately if
called from within service workers that are currently installing
(i.e. if update() is called in the |install|-event-handler).
This change implements this behavior and updates the WPT to match the
spec.
Bug: 895845
Change-Id: Ie07563e5ac8260554ef0947be4cb020124cfeddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626600
Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663695}