[Gecko Bug 1555030] Add NS_FRAME_SVG_LAYOUT into SVGViewFrame and nsSVGStopFrame. #17106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid hitting the assertion for ResizeObserver, which calls GetBBox() for all SVG elements. Note: If the target has SVG layout and its primary frame cannot be queries as nsSVGDisplayableFrame, we return a default gfxRect(). And always returning a default gfxRect() on <view> or <stop> element makes ResizeObserver doesn't report it (because it is always not active). This behavior is the same as what Google Chrome has. (i.e. No event is fired.) Differential Revision: https://phabricator.services.mozilla.com/D32904 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1555030 gecko-commit: 58a92f5eff76adb20b44e6a37c58e63387be6b62 gecko-integration-branch: autoland gecko-reviewers: dholbert, longsonr
wpt-pr-bot
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid hitting the assertion for ResizeObserver, which calls GetBBox()
for all SVG elements.
Note:
If the target has SVG layout and its primary frame cannot be queries as
nsSVGDisplayableFrame, we return a default gfxRect(). And always
returning a default gfxRect() on or element makes ResizeObserver
doesn't report it (because it is always not active). This behavior
is the same as what Google Chrome has. (i.e. No event is fired.)
Differential Revision: https://phabricator.services.mozilla.com/D32904
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1555030
gecko-commit: 58a92f5eff76adb20b44e6a37c58e63387be6b62
gecko-integration-branch: autoland
gecko-reviewers: dholbert, longsonr