[css-flexbox] Don't set height to 0 before ForceLayout #17120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 31, 2019
It's not necessary and causes problems in LayoutNG when we reuse the cached fragment inside of ForceLayout (nothing will set the height to the correct value) In the specific testcase, we incorrectly think that the block has a percentage-sized child due to the abspos item. Bug: 967061 Change-Id: If6fabc93173f025966f359510e5b600914376e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638192 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665233}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1638192
branch
from
713cbdf
to
038aa47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary and causes problems in LayoutNG when we reuse the
cached fragment inside of ForceLayout (nothing will set the height
to the correct value)
In the specific testcase, we incorrectly think that the block has a
percentage-sized child due to the abspos item.
Bug: 967061
Change-Id: If6fabc93173f025966f359510e5b600914376e45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638192
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665233}