Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Reland "Adding support to bitmaprenderer in OffscreenCanvas"" #17121

Merged
merged 1 commit into from Jun 3, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 31, 2019

Registering the factory on OffscreenCanvas in modules, adding
ImageBitmapRenderer to the union type for OffscreenCanvas.
Adding new functionality to bitmaprenderer to let it be used
in offscreencanvas.
Changing IDL and some tests to validate new functionality.
Adding a new virtual test to guarantee testing validation
of trasnsfertooffscreencanvas for bitmaprenderer.

Added bug: 969151 for the two missing tests.

TBR=chrishtr

Bug: 907141
Change-Id: I7c611952686aabdf2eb3df8ffe5ca73a69ae97f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638919
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665260}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Registering the factory on OffscreenCanvas in modules, adding
ImageBitmapRenderer to the union type for OffscreenCanvas.
Adding new functionality to bitmaprenderer to let it be used
in offscreencanvas.
Changing IDL and some tests to validate new functionality.
Adding a new virtual test to guarantee testing validation
of trasnsfertooffscreencanvas for bitmaprenderer.

Added bug: 969151 for the two missing tests.

TBR=chrishtr

Bug: 907141
Change-Id: I7c611952686aabdf2eb3df8ffe5ca73a69ae97f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638919
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665260}
@Hexcles
Copy link
Member

Hexcles commented Jun 3, 2019

/html/dom/interfaces.https.html is flaky on Firefox. I don't see this PR actually causes that flake: it merely touches html.idl, and the flaky EventHandlerNonNull isn't changed by this PR.

@Hexcles Hexcles merged commit 209c15c into master Jun 3, 2019
@Hexcles Hexcles deleted the chromium-export-cl-1638919 branch June 3, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants