[Gecko Bug 1556511] part 1: Mark the outer SVG frame as needing a reflow, when its viewBox attribute changes. #17253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x attribute changes. The viewBox attribute establishes an aspect ratio, which may influence the size of the outer SVG element. So when the viewBox attribute changes, we have to reflow to potentially update the frame size. This patch achieves this by sharing an existing codepath for handling changes to width & height. Differential Revision: https://phabricator.services.mozilla.com/D33898 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1556511 gecko-commit: aba9b5d525af1b48929de552224626799931ff3e gecko-integration-branch: central gecko-reviewers: longsonr
…ement. Differential Revision: https://phabricator.services.mozilla.com/D34108 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1556511 gecko-commit: bab948f512c2f5ffe5a6638676143c7063bf2ad3 gecko-integration-branch: central gecko-reviewers: longsonr
wpt-pr-bot
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The viewBox attribute establishes an aspect ratio, which may influence the size
of the outer SVG element. So when the viewBox attribute changes, we have to
reflow to potentially update the frame size. This patch achieves this by
sharing an existing codepath for handling changes to width & height.
Differential Revision: https://phabricator.services.mozilla.com/D33898
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1556511
gecko-commit: aba9b5d525af1b48929de552224626799931ff3e
gecko-integration-branch: central
gecko-reviewers: longsonr