Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LayoutNG] Skip "replaced % resolution" quirk on ortho-roots. #17381

Merged
merged 1 commit into from Jun 18, 2019
Merged

[LayoutNG] Skip "replaced % resolution" quirk on ortho-roots. #17381

merged 1 commit into from Jun 18, 2019

Commits on Jun 18, 2019

  1. [LayoutNG] Skip "replaced % resolution" quirk on ortho-roots. 

    This is about an undocumented quirk. I raised
whatwg/quirks#46 for it.

LayoutNG currently cannot handle this situation, because we don't store
the inline-size to use in replaced percentage resolution (only the
block-size). However, I find it hard to believe that there'd be any
specific expectations to how this is supposed to work if a table cell
has a definite block-size, and a descendant establishes an orthogonal
writing-mode root. So just ignore it and use regular percentage size
resolution in these cases.

Bug: 967069
Change-Id: Iac61abe80f4f949017cc161855b2223ec4503812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664075
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670126}
    @mstensho @chromium-wpt-export-bot
    mstensho authored and chromium-wpt-export-bot committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    a0ea38f View commit details
    Browse the repository at this point in the history