[LargestContentfulPaint] Replace responseEnd with loadTime #17945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 19, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1710682
branch
4 times, most recently
from
86a8ff5
to
2abc90c
Compare
This CL replaces responseEnd with loadTime. Before, responseEnd would be used and would be problematic for memory cached images. We change it to loadTime, the time at which LayoutObject::ImageNotifyFinished is called. This time has the advantage of being independent of the memory cache and being after the image has been appended to the DOM, as shown by a test. To implement loadTime, we use a new HashMap. This HashMap populates the timestamps that will be used in ImageRecords. We cannot use the existing data structures because this happens before we know whether the image will be added to the set of visible or invisible images, etc. Bug: 982046, 965505 Change-Id: I50d4f304a35b60409c58c54a5bd912e7d15825e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710682 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680096}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1710682
branch
from
2abc90c
to
64c46c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL replaces responseEnd with loadTime. Before, responseEnd would be
used and would be problematic for memory cached images. We change it to
loadTime, the time at which LayoutObject::ImageNotifyFinished is called.
This time has the advantage of being independent of the memory cache and
being after the image has been appended to the DOM, as shown by a test.
To implement loadTime, we use a new HashMap. This HashMap populates the
timestamps that will be used in ImageRecords. We cannot use the existing
data structures because this happens before we know whether the image
will be added to the set of visible or invisible images, etc.
Bug: 982046, 965505
Change-Id: I50d4f304a35b60409c58c54a5bd912e7d15825e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710682
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680096}