[Gecko Bug 1540688] Sort all-lowercase XHR headers as if all-uppercase. #17968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the underscore sort after letters, which works around tacit assumption that such custom headers don't sort to the beginning of the string. Differential Revision: https://phabricator.services.mozilla.com/D31786 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1540688 gecko-commit: 40d1bf211aa05149aa77bbf0152633ce0a589384 gecko-integration-branch: autoland gecko-reviewers: baku, annevk
wpt-pr-bot
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the underscore sort after letters, which works around tacit
assumption that such custom headers don't sort to the beginning of the
string.
Differential Revision: https://phabricator.services.mozilla.com/D31786
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1540688
gecko-commit: 40d1bf211aa05149aa77bbf0152633ce0a589384
gecko-integration-branch: autoland
gecko-reviewers: baku, annevk