Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[performance-timeline] make sure performance entries are not clonable #18043

Merged
merged 2 commits into from Aug 19, 2019
Merged

[performance-timeline] make sure performance entries are not clonable #18043

merged 2 commits into from Aug 19, 2019

Conversation

yoavweiss
Copy link
Contributor

No description provided.

@yoavweiss yoavweiss requested a review from npm1 July 24, 2019 15:14
@npm1
Copy link
Contributor

npm1 commented Jul 24, 2019

Is it possible to use assert_throws?

@yoavweiss
Copy link
Contributor Author

Is it possible to use assert_throws?

(apologies for missing your comment...)
@npm1 - I don't think so, as the throwing happens inside a different document, and one where the asserts are not defined.
(unless you're suggesting modifying the tests in such a way that the top frame will try to clone its entries onto the iframe - is this what you're suggesting?)

npm1
npm1 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in that case we can land without assert_throws.

performance-timeline/resources/postmessage-entry.html Show resolved Hide resolved
@yoavweiss yoavweiss merged commit a1edc49 into web-platform-tests:master Aug 19, 2019
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
@yoavweiss @natechapin
[performance-timeline] make sure performance entries are not clonable (…
f0a0d2a 
…web-platform-tests#18043)

* Add a performance-timeline test making sure performance entries are not clonable

* Review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npm1 npm1 npm1 approved these changes

@igrigorik igrigorik Awaiting requested review from igrigorik

@plehegar plehegar Awaiting requested review from plehegar

@toddreifsteck toddreifsteck Awaiting requested review from toddreifsteck

Assignees

@igrigorik igrigorik

Labels
performance-timeline wg-webperf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yoavweiss @npm1 @igrigorik @wpt-pr-bot @moz-wptsync-bot