Reland "[CSS] Treat viewport-relative units as computationally independent" #18723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 28, 2019
…ndent" This reverts commit 182115f0e3d61178991b3394e0dd50489df5ea30. Reason for revert: We are relanding this to prove whether this patch was or was not the cause of the style and layout performance regression. Original change's description: > Revert "[CSS] Treat viewport-relative units as computationally independent" > > This is a speculative revert in order to either confirm or eliminate it > as a source for a hard to track down persistent performance regression. > > This reverts r679183 (commit 6b846d3689b9038c73d87ecbab61670e91c7e051). > > Bug: 993476 > Tbr: pdr@chromium.org > Change-Id: I37566d32fb0853590e72299fdc0f281c712bf027 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764195 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689475} TBR=pdr@chromium.org,eae@chromium.org,xiaochengh@chromium.org,andruud@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993476 Change-Id: I0292aa653c23ae3b2a751f62ee210626aeb71bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774683 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691182}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1774683
branch
from
96149bf
to
a76db8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 182115f0e3d61178991b3394e0dd50489df5ea30.
Reason for revert: We are relanding this to prove whether this patch was or was not the cause of the style and layout performance regression.
Original change's description:
TBR=pdr@chromium.org,eae@chromium.org,xiaochengh@chromium.org,andruud@chromium.org
Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 993476
Change-Id: I0292aa653c23ae3b2a751f62ee210626aeb71bbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774683
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691182}