Implement checks in the proper order in XR::requestSession #18754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 29, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1764325
branch
6 times, most recently
from
2ad8323
to
bb259f7
Compare
The number and ordering of checks in XR::requestSession was not compliant with the spec. This CL fixes that. There is still a remaining issue around multiple immersive requests from different pages simultaneously, but that should be done as separate work. Link to relevant spec section: https://immersive-web.github.io/webxr/#dom-xr-requestsession Bug: 962991, 987073 Change-Id: I590eed311583542ceadc208047e40c3bf260e421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764325 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#693455}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1764325
branch
from
bb259f7
to
3f87625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number and ordering of checks in XR::requestSession was not
compliant with the spec. This CL fixes that. There is still a remaining
issue around multiple immersive requests from different pages
simultaneously, but that should be done as separate work.
Link to relevant spec section:
https://immersive-web.github.io/webxr/#dom-xr-requestsession
Bug: 962991, 987073
Change-Id: I590eed311583542ceadc208047e40c3bf260e421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764325
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693455}