[WPT/referrer-policy] Dedup some similar <srcdoc>-related tests #18800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 3, 2019
|
Timing out just because many tests are affected #7660. |
[1] will (a) rename test files largely, (b) split out <srcdoc>-related subtests for image requests into separate test files, and (c) omit some of the subtests, because they are redundant, or due to mismatches between how tests are executed before and after [1]. It is hard to track the mixture of (a), (b) and (c), especially to see whether there are regressions by [1]. To remove the effect of (c) to some extent, this CL skips some <srcdoc>-related tests (before [1]). Ideally, if we can omit (c) from [1], then we can estimate the number of passing/failing tests before/after [1] by simple calculation, making it easier to check whether [1] causes regressions. The skipped tests have similar (non-skipped) tests so I expect this CL doesn't substantially reduce test coverage. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1586548/ Bug: 906850 Change-Id: I4b791ba3a6b7512fea1a2e4debf67f382b966906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777094 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#692734}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1777094
branch
from
8cab3d7
to
e6dec9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] will
(a) rename test files largely,
(b) split out <srcdoc>-related subtests for image requests
into separate test files, and
(c) omit some of the subtests, because they are redundant,
or due to mismatches between how tests are executed
before and after [1].
It is hard to track the mixture of (a), (b) and (c),
especially to see whether there are regressions by [1].
To remove the effect of (c) to some extent,
this CL skips some <srcdoc>-related tests (before [1]).
Ideally, if we can omit (c) from [1], then we can estimate
the number of passing/failing tests before/after [1]
by simple calculation, making it easier to check whether
[1] causes regressions.
The skipped tests have similar (non-skipped) tests so I expect
this CL doesn't substantially reduce test coverage.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1586548/
Bug: 906850
Change-Id: I4b791ba3a6b7512fea1a2e4debf67f382b966906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777094
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692734}