Revert "[LayoutNG] Fix incorrect rounding in ShapingLineBreaker" #19041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a4d21f7f7faa39ce99f96b81996b6ece702f501e. Reason for revert: This is likely breaking - external/wpt/css/css-multicol/multicol-width-ch-001.xht - css2.1/t1602-c546-txt-align-00-b.html - external/wpt/css/css-text/white-space/trailing-space-align-start.tentative.html Original change's description: > [LayoutNG] Fix incorrect rounding in ShapingLineBreaker > > This patch fixes the rounding the end position to the same > direction as the rounding the start position. Before this > change, the end position was rounded to the line-end > direction. This may have resulted in slightly larger > available space than the given one. > > Although the error is slight, such an error can cause a large > visual differences because of an optimization. |NGLineBreaker| > determines the overflow by comparing the result width to the > available width, and if overflow occurs, it assumes that it > cannot break the result further when it tries to rewind. > > Bug: 1002442 > Change-Id: Iebee80117c9930eade029c45c561236b8916981a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797954 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696262} TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org Change-Id: Ie9255f9bfc01427550d58d92135b4ce25db27583 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801769 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#696316}
wpt-pr-bot
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a4d21f7f7faa39ce99f96b81996b6ece702f501e.
Reason for revert: This is likely breaking
Original change's description:
TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org
Change-Id: Ie9255f9bfc01427550d58d92135b4ce25db27583
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801769
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696316}