Move 'autofocus' IDL attribute to HTMLOrSVGElement #19108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 17, 2019
crrev.com/697042 changed the autofocus behavior, and this CL just changes the IDL attribute. Note: We need to add 'autofocus' to svg_attribute_names.json5 because generated code for 'Reflect' needs svg_names::kAutofocusAttr. html_names::kAutofocusAttr and svg_names::kAutofocusAttr have an identical value. I2IS: https://groups.google.com/a/chromium.org/d/msg/blink-dev/g8MP8KUf96w/360rLewrDwAJ Bug: 995679 Change-Id: I4c7a1ad72d14c4e1e54d8455935b1255805fb384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808617 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697087}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1808617
branch
from
8f3a777
to
c7a7396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crrev.com/697042 changed the autofocus behavior, and this CL just changes
the IDL attribute.
Note: We need to add 'autofocus' to svg_attribute_names.json5
because generated code for 'Reflect' needs svg_names::kAutofocusAttr.
html_names::kAutofocusAttr and svg_names::kAutofocusAttr have
an identical value.
I2IS: https://groups.google.com/a/chromium.org/d/msg/blink-dev/g8MP8KUf96w/360rLewrDwAJ
Bug: 995679
Change-Id: I4c7a1ad72d14c4e1e54d8455935b1255805fb384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808617
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697087}