Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcdownload: returns 1 if 'No complete TaskCluster runs found for ref' #19187

Merged
merged 1 commit into from Sep 21, 2019
Merged

tcdownload: returns 1 if 'No complete TaskCluster runs found for ref' #19187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/ci/tcdownload.py
View file
Open in desktop
Expand Up @@ -71,7 +71,7 @@ def run(*args, **kwargs):

if not taskgroups:
logger.error("No complete TaskCluster runs found for ref %s" % kwargs["ref"])
return
return 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't sys.exit(run(None, vars(kwargs))) or similar needed below for this to work?

Copy link
Contributor Author

@psaavedra psaavedra Sep 20, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of the run() function for tc-download is captured by wpt in

wpt/tools/wpt/wpt.py

Line 166 in 5336ed0

sys.exit(int(rv))
)

Actually, the tc-download is a subcommand of wpt. Example:

./wpt tc-download --ref a7f3642cf9af7321211ac05cd06e0512fb4d6372  ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW @clopez has an interesting extension for this which we are using to get results from task-cluster and upload it the wpt.fyi repository: psaavedra@c093e31

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, then I understand the context. Writing a longish explanation in the commit message is OK and helpful in review.


for taskgroup in taskgroups:
taskgroup_url = "https://queue.taskcluster.net/v1/task-group/%s/list"
Expand Down