Do not simplify calculation across math functions #19309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 25, 2019
The existing code is too aggressive in simplifying calc() expressions that, math functions (min/max etc) can be simplified away when they can be directly resolved. This doesn't match the spec (*), and is fixed in this patch. (*) https://drafts.csswg.org/css-values-4/#math-function-simplify-a-calculation Bug: 825895 Change-Id: Id5796299da50e40b09bc38bf0271c8f5cd7897de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825325 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700132}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1825325
branch
from
47a40df
to
8beff11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code is too aggressive in simplifying calc() expressions
that, math functions (min/max etc) can be simplified away when they
can be directly resolved. This doesn't match the spec (*), and is fixed
in this patch.
(*) https://drafts.csswg.org/css-values-4/#math-function-simplify-a-calculation
Bug: 825895
Change-Id: Id5796299da50e40b09bc38bf0271c8f5cd7897de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825325
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700132}