Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Payments] Enable shipping and contact info delegation [4/5]" #19329

Merged
merged 1 commit into from Sep 26, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This reverts commit 3dd95e215bbb616913239ed37e61d15e894cf561.

Reason for revert: Suspect for android-builder-perf compile failures:
https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/115402

Original change's description:

[Payments] Enable shipping and contact info delegation [4/5]

This cl implements shipping address/option change events for PH. With
this change payment handlers can notify the merchant when the user
changes the selected shipping address/option, and wait for updated
details (e.g. new shipping cost, etc) from merchant.

For overall flow please check
https://chromium-review.googlesource.com/c/chromium/src/+/1779003

Bug: 984694
Change-Id: Id881ba22bf4c846a4570801bacc49e5d4e89a72b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804557
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700238}

TBR=rouslan@chromium.org,mkwst@chromium.org,sahel@chromium.org

Change-Id: I74d8507117fc9a0000142071b71146d14f17f8bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827544
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700289}

This reverts commit 3dd95e215bbb616913239ed37e61d15e894cf561.

Reason for revert: Suspect for android-builder-perf compile failures:
https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/115402

Original change's description:
> [Payments] Enable shipping and contact info delegation [4/5]
>
> This cl implements shipping address/option change events for PH. With
> this change payment handlers can notify the merchant when the user
> changes the selected shipping address/option, and wait for updated
> details (e.g. new shipping cost, etc) from merchant.
>
> For overall flow please check
> https://chromium-review.googlesource.com/c/chromium/src/+/1779003
>
> Bug: 984694
> Change-Id: Id881ba22bf4c846a4570801bacc49e5d4e89a72b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804557
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#700238}

TBR=rouslan@chromium.org,mkwst@chromium.org,sahel@chromium.org

Change-Id: I74d8507117fc9a0000142071b71146d14f17f8bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827544
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700289}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9a229b6 into master Sep 26, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-18490eddb3 branch September 26, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants