Fix SMIL interval restarting #19446
Merged
Fix SMIL interval restarting #19446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 1, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1821922
branch
from
9c783c3
to
ecd7766
Compare
When an interval restarts we won't necessarily get a new interval, but just adjust the current interval (which could then potentially end). Change CheckAndUpdateInterval(...) to reflect this, and narrow the restart criteria in UpdateActiveState(...). UpdateActiveState(...) was also only checking for "inactive" -> "active/frozen" transitions to 'begin', but we need to check for transitions from "frozen" as well. Also re-order the check for 'end' so that it is before the one 'begin'. This will mean that events should get dispatched like: 'begin', 'end', 'begin' and 'end' when we encounter a restart (like in the testcase), rather than as previously: 'begin', 'begin', 'end' and 'end'. Bug: 998526 Change-Id: I56b2391fdcc22f3a22332d6eeb6aa469225497f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821922 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#701710}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1821922
branch
from
ecd7766
to
71cbbd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an interval restarts we won't necessarily get a new interval, but
just adjust the current interval (which could then potentially end).
Change CheckAndUpdateInterval(...) to reflect this, and narrow the
restart criteria in UpdateActiveState(...).
UpdateActiveState(...) was also only checking for
"inactive" -> "active/frozen" transitions to 'begin', but we need to
check for transitions from "frozen" as well.
Also re-order the check for 'end' so that it is before the one 'begin'.
This will mean that events should get dispatched like:
'begin', 'end', 'begin' and 'end'
when we encounter a restart (like in the testcase),
rather than as previously:
'begin', 'begin', 'end' and 'end'.
Bug: 998526
Change-Id: I56b2391fdcc22f3a22332d6eeb6aa469225497f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821922
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701710}