[Gecko Bug 1582407] Fix MediaRecorder-pause-resume.html to avoid start() ambiguities. #19502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec allows for MediaRecorder.start() to hold the "start" event until it has collected some actual data. This means "pause" and "resume" events can occur before "start", on the contrary of this testcase. This patch avoids this ambiguity by: 1) Drawing a frame to the canvas so that the track contains some real data. 2) Wait for "start" before pause()ing, to ensure "start" comes first. Note that without 1), 2) could wait indefinitely, resulting in a timeout. Differential Revision: https://phabricator.services.mozilla.com/D46470 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1582407 gecko-commit: d7ab956c296257c99630aa0d4e91d41434c55137 gecko-integration-branch: autoland gecko-reviewers: jib
wpt-pr-bot
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec allows for MediaRecorder.start() to hold the "start" event until it
has collected some actual data. This means "pause" and "resume" events can occur
before "start", on the contrary of this testcase.
This patch avoids this ambiguity by:
Note that without 1), 2) could wait indefinitely, resulting in a timeout.
Differential Revision: https://phabricator.services.mozilla.com/D46470
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1582407
gecko-commit: d7ab956c296257c99630aa0d4e91d41434c55137
gecko-integration-branch: autoland
gecko-reviewers: jib