[Gecko Bug 1585882] Fix needs_frame() check to account for the case where an ancestor of us has been reconstructed regularly, not via lazy frame construction. #19535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us has been reconstructed regularly, not via lazy frame construction. This is a pre-existing bug, and this would be enough to fix the website, but this is still not 100% correct. More on that in a second. Differential Revision: https://phabricator.services.mozilla.com/D48134 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1585882 gecko-commit: df80909c82323e153691e01b3a15d19f4929cba0 gecko-integration-branch: autoland gecko-reviewers: heycam
wpt-pr-bot
approved these changes
Oct 5, 2019
…ame due to a DOM mutation of siblings. This fixes another edge-case that I thought of while debugging this, I think this makes our behavior correct now. The comment and test-case should be self-descriptive. Differential Revision: https://phabricator.services.mozilla.com/D48135 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1585882 gecko-commit: ea10c9b6a81d795ab96a16e07ea2c64f0a0de247 gecko-integration-branch: autoland gecko-reviewers: heycam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-existing bug, and this would be enough to fix the website, but
this is still not 100% correct. More on that in a second.
Differential Revision: https://phabricator.services.mozilla.com/D48134
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1585882
gecko-commit: df80909c82323e153691e01b3a15d19f4929cba0
gecko-integration-branch: autoland
gecko-reviewers: heycam