Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common/sleep.py to resource-timing/sleep.py #19597

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@zcorpan
Copy link
Member

zcorpan commented Oct 9, 2019

Part of #17913.


I was going to delete this seemingly unused file, but when I looked closer I found it was used by resource-timing/resource-timing-level1.sub.html, imported in resource-timing/SyntheticResponse.py.

I could be convinced that other tests may need this as well such that it should stay in common/, but right now it's not commonly used...

Copy link
Contributor

yoavweiss left a comment

LGTM

@yoavweiss yoavweiss merged commit 3e53064 into master Oct 17, 2019
10 checks passed
10 checks passed
Azure Pipelines Build #20191009.76 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.