Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for NFC API in non-visible document #19664

Merged
merged 1 commit into from Oct 15, 2019
Merged

Add tests for NFC API in non-visible document #19664

merged 1 commit into from Oct 15, 2019

Conversation

xiuqijix
Copy link
Contributor

No description provided.

@Honry Honry requested a review from leonhsl October 14, 2019 03:16
Honry
Honry approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @leonhsl, would you take another eye on it?

@Honry Honry merged commit 9f31d49 into web-platform-tests:master Oct 15, 2019
@xiuqijix xiuqijix deleted the webnfc_visible branch October 16, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Honry Honry Honry approved these changes

@leonhsl leonhsl leonhsl approved these changes

@kenchris kenchris Awaiting requested review from kenchris

Assignees

@kenchris kenchris

Labels
web-nfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xiuqijix @Honry @leonhsl @kenchris @wpt-pr-bot