Reland "[Trusted Types] Remove TrustedURL." #19768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a84f1c65c3511283481a5a737a4b51d0abae7a92. Reason for revert: wrong revert Original change's description: > Revert "[Trusted Types] Remove TrustedURL." > > This reverts commit 005483fe14c968325e6c8735eb6077049ee997ef. > > Reason for revert: <INSERT REASONING HERE> > ../../third_party/blink/renderer/core/page/scrolling/text_fragment_anchor_test.cc(8,10): fatal error: 'third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h' file not found > #include "third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h" > > Original change's description: > > [Trusted Types] Remove TrustedURL. > > > > The current Trusted Types spec no longer supports TrustedURL. This CL adapts > > to the spec. > > > > Bug: 1002555 > > Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 > > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > > Reviewed-by: Mike West <mkwst@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706886} > > TBR=vogelheim@chromium.org,mkwst@chromium.org > > Change-Id: I9012ad7c3f9f01389ab1aa7a90d5beb7873eab2c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1002555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866974 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706979} TBR=vogelheim@chromium.org,lanwei@chromium.org,mkwst@chromium.org Change-Id: Idfd715701037a3b3dfabe2adbb8f74b2e98625a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865686 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706986}
wpt-pr-bot
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a84f1c65c3511283481a5a737a4b51d0abae7a92.
Reason for revert: wrong revert
Original change's description:
TBR=vogelheim@chromium.org,lanwei@chromium.org,mkwst@chromium.org
Change-Id: Idfd715701037a3b3dfabe2adbb8f74b2e98625a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865686
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706986}