CSS: Update min-width and min-height parsing WPTs #19968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 29, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1885860
branch
2 times, most recently
from
de45a17
to
e648506
Compare
min-width and min-height were previously defined in https://drafts.csswg.org/css-box-3/ They supported 'fit-content' as a keyword, not as a function. `[ [<length> | <percentage>] && [border-box | content-box]? ] | available | min-content | max-content | fit-content` Now min-width and min-height are exclusively defined in https://drafts.csswg.org/css-sizing-3/ They support fit-width as a function, not as a keyword. `auto | <length-percentage> | min-content | max-content | fit-content(<length-percentage>)` Bug: 856648 Change-Id: I04230a5a530b1455fbd17bbf0aceeabacdd188d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885860 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#711067}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1885860
branch
from
e648506
to
feb2248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min-width and min-height were previously defined in
https://drafts.csswg.org/css-box-3/
They supported 'fit-content' as a keyword, not as a function.
[ [\<length> | \<percentage>] && [border-box | content-box]? ] | available | min-content | max-content | fit-contentNow min-width and min-height are exclusively defined in
https://drafts.csswg.org/css-sizing-3/
They support fit-width as a function, not as a keyword.
auto | \<length-percentage> | min-content | max-content | fit-content(\<length-percentage>)Bug: 856648
Change-Id: I04230a5a530b1455fbd17bbf0aceeabacdd188d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885860
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711067}