Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sec-fetch-mode from no-cors to navigate for <embed> / <object>. #20251

Merged
merged 1 commit into from Nov 18, 2019
Merged

Change sec-fetch-mode from no-cors to navigate for <embed> / <object>. #20251

merged 1 commit into from Nov 18, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 14, 2019 •
edited

See whatwg/fetch#948 .

Bug: 1011724
Change-Id: I546752f3d0120f71cc810bfb17f960789e6c53dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917259
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@google.com>
Cr-Commit-Position: refs/heads/master@{#715664}

wpt-pr-bot
wpt-pr-bot approved these changes Nov 14, 2019
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@iVanlIsh @chromium-wpt-export-bot
Change sec-fetch-mode from no-cors to navigate for <embed> / <o…
650fbd1 
…bject>.

See whatwg/fetch#948 .

Bug: 1011724
Change-Id: I546752f3d0120f71cc810bfb17f960789e6c53dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917259
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@google.com>
Cr-Commit-Position: refs/heads/master@{#715664}
@KyleJu
Copy link
Contributor

KyleJu commented Nov 18, 2019

The followings are flaky on firefox nightly
Screen Shot 2019-11-18 at 12 16 15 PM

@KyleJu
Copy link
Contributor

KyleJu commented Nov 18, 2019 •
edited

all the flaky tests are either timeout or failures on Firefox here . I think this PR doesn't introduce any regressions.

@stephenmcgruer stephenmcgruer merged commit bddf074 into master Nov 18, 2019
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-1917259 branch November 18, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chromium-wpt-export-bot @KyleJu @wpt-pr-bot @stephenmcgruer @iVanlIsh