Follow NDEFScanOptions dictionary spec #20308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 19, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1921930
branch
2 times, most recently
from
d99dd83
to
f6e77a9
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1921930
branch
from
f6e77a9
to
36a7149
Compare
NDEFScanOptions dictionary spec was changed. So we should follow new spec for it. I updated the dictionary. Bug: 520391,1001507 Change-Id: I427b572e597bd55c719c18922b92c6419b473a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921930 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#717623}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1921930
branch
from
36a7149
to
01597a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDEFScanOptions dictionary spec was changed.
So we should follow new spec for it.
I updated the dictionary.
Bug: 520391,1001507
Change-Id: I427b572e597bd55c719c18922b92c6419b473a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921930
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#717623}