New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResourceTiming] Add test for new TAO check #20320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
45dde0b
to
93e6454
Compare
This CL modifies the tests as follows: * '*' is now the default TAO header. This means most sandwich tests use '*'. * Another resource is added to crossorigin-sandwich-TAO to test the case in which the header is the page origin, and this should now fail (this was the test before this CL). * The resources in crossorigin-sandwich-TAO are changed to images because it's not super clear how iframes will be handled. Bug: 1022816 Change-Id: I2110653a5240cff825d3130cfe6dc64e8d2f8e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924635 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#716652}
93e6454
to
a9da6e6
Compare
Ok, I did not see that this is complaining and the Chromium patch landed, woops. Some things:
@foolip for help! If my reading is right and the problem is just the test messages, I can fix that but I don't want to unsync the chromium and GitHub version further. |
Chatted with @npm1 . The |
Ah still failing... @Hexcles the Firefox failure seems to be caused by Firefox computing separate timestamps which means sometimes the values will be close but not equal and other times the values will be equal (so the test is considered flaky). Can we force-merge in this case? |
This sounds to me like an implementation problem. I'm not a domain expert so I'll trust your judgement here (file a bug to Firefox if needed.) |
Thanks @Hexcles for helping out with this! |
This CL modifies the tests as follows:
which the header is the page origin, and this should now fail (this was the
test before this CL).
not super clear how iframes will be handled.
Bug: 1022816
Change-Id: I2110653a5240cff825d3130cfe6dc64e8d2f8e23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924635
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716652}