Implement new pseudoElement interface on KeyframeEffect #20373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 21, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1921343
branch
4 times, most recently
from
5e13a45
to
1114191
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1921343
branch
from
1114191
to
2918c0f
Compare
|
RESYNCED: blink-wpt-bot has now re-synced and new test changes have been added. This may be merged as normal Formerly:
|
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1921343
branch
4 times, most recently
from
efc9e6c
to
0e3f50c
Compare
Make target() return the originating element if target_ is a PseudoElement (EventTarget still returns the layout object). Add pseudoElement() property which returns the target pseudo-selector if the target is a pseudo-element (null otherwise). Invalid and unsupported pseudo-elements will still return a selector and the originating element (from target()) but will not animated (EventTarget returns null). Add pseudoElement option to KeyframeEffect constructor. Change-Id: Id7d16ea6966c533e56d1170462ff60a79b277fd5 Bug: 981894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921343 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#726506}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1921343
branch
from
0e3f50c
to
5dc4b6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make target() return the originating element if target_ is a
PseudoElement (EventTarget still returns the layout object).
Add pseudoElement() property which returns the target pseudo-selector
if the target is a pseudo-element (null otherwise).
Invalid and unsupported pseudo-elements will still return a selector
and the originating element (from target()) but will not animated
(EventTarget returns null).
Add pseudoElement option to KeyframeEffect constructor.
Change-Id: Id7d16ea6966c533e56d1170462ff60a79b277fd5
Bug: 981894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921343
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726506}