Fixed not lazily loading for explicit loading=lazy image #20624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 5, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1950104
branch
from
4bdadc5
to
e0b2d15
Compare
Previously when a image element is invisible, it loads image eagerly for both 'auto' and 'lazy' by https://chromium-review.googlesource.com/c/chromium/src/+/1668710 But when attribute is set 'lazy' explicitly, we can still use lazy loading because lazy loading is intended. Bug: 1027153 Change-Id: Ibb0ad782049c66863d242d929f1e94fa6ddd1ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950104 Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Scott Little <sclittle@chromium.org> Commit-Queue: Wanchang Ryu <wanchang.ryu@lge.com> Cr-Commit-Position: refs/heads/master@{#721911}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1950104
branch
from
e0b2d15
to
63de526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a image element is invisible, it loads image eagerly for
both 'auto' and 'lazy' by
https://chromium-review.googlesource.com/c/chromium/src/+/1668710
But when attribute is set 'lazy' explicitly, we can still use lazy
loading because lazy loading is intended.
Bug: 1027153
Change-Id: Ibb0ad782049c66863d242d929f1e94fa6ddd1ed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950104
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Wanchang Ryu <wanchang.ryu@lge.com>
Cr-Commit-Position: refs/heads/master@{#721911}