Fix markerUnits=strokeWidth combined with non-scaling-stroke #20656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 6, 2019
When vector-effect=non-scaling-stroke applies to an element we need to adjust the stroke width used to compute the local coordinate space for a marker with markerUnits=strokeWidth. Remove our old (pixel)test in favor of two new WPTs. Fixed: 1031203 Change-Id: I569fadca7806d9bef03c5407a2a6ff5d0ca4faef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955586 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#722470}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1955586
branch
from
40f81d0
to
c344528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vector-effect=non-scaling-stroke applies to an element we need to
adjust the stroke width used to compute the local coordinate space for a
marker with markerUnits=strokeWidth.
Remove our old (pixel)test in favor of two new WPTs.
Fixed: 1031203
Change-Id: I569fadca7806d9bef03c5407a2a6ff5d0ca4faef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955586
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#722470}