Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assertion failures useful on UAs not supporting lazy load #20780

Merged
merged 1 commit into from Dec 15, 2019

Conversation

domfarolino
Copy link
Member

Just realized that these have rather opaque errors in UAs that don't support lazy load. I didn't catch this in review, so I made these changes in a PR

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@domfarolino domfarolino merged commit 361a62e into master Dec 15, 2019
@domfarolino domfarolino deleted the domfarolino/fix-lazyload-assert-messages branch December 15, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants