Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS4Pseudo] Added 2 tests and 1 reference on selection and text-shadow #20802

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Dec 17, 2019

selection-text-shadow-006-manual.html
selection-text-shadow-016-ref.html
selection-text-shadow-016.html

This PR is a followup to
#18217
as it addresses all of the requested modifications over there.

I also removed 'position: absolute;', 'left' and 'top' offsets from both tests and used instead 'margin-left', 'margin-top' and static positioning.
Finally, I added some tiny editorial improvements.

@TalbotG
Copy link
Contributor Author

TalbotG commented Dec 17, 2019

@fantasai , please review this. Thank you.

@fantasai fantasai merged commit b5b7813 into web-platform-tests:master Dec 18, 2019
@TalbotG TalbotG deleted the CSS4Pseudo-GT-PR12 branch December 18, 2019 22:34
@TalbotG TalbotG removed the request for review from plinss July 26, 2020 18:03
@TalbotG TalbotG assigned TalbotG and unassigned frivoal Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants