Use Image::SizeAsFloat() and unsnapped rectangle in ImagePainter #20831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 18, 2019
The pixel-snapping of the destination rectangle can end up distorting the geometry use for painting an SVG image preserveAspectRatio is used - the larger the aspect ratio, the larger the error. By passing the unsnapped rectangle to LayoutImageResource::GetImage, and using Image::SizeAsFloat() to compute the source rectangle of the image, e can minimize the error and allow the Image in question (an SVGImage) to perform compensation for the difference in aspect ratio between the snapped and unsnapped rectangles. This means that the painted result will better approximate the intended rendering. Also clean up accesses to the LayoutImageResource and ImageResourceContent by adding and using local variables for them. Bug: 812239 Change-Id: I0778648e7dd6fcca778a95123509f15b3519564c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969831 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#726375}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1969831
branch
from
267a526
to
0c763ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pixel-snapping of the destination rectangle can end up distorting
the geometry use for painting an SVG image preserveAspectRatio is used -
the larger the aspect ratio, the larger the error.
By passing the unsnapped rectangle to LayoutImageResource::GetImage, and
using Image::SizeAsFloat() to compute the source rectangle of the image,
e can minimize the error and allow the Image in question (an SVGImage)
to perform compensation for the difference in aspect ratio between the
snapped and unsnapped rectangles. This means that the painted result
will better approximate the intended rendering.
Also clean up accesses to the LayoutImageResource and ImageResourceContent
by adding and using local variables for them.
Bug: 812239
Change-Id: I0778648e7dd6fcca778a95123509f15b3519564c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969831
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#726375}