Refactor data-feeding for ImageDocument/ImageDocumentParser #20889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 20, 2019
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1975921
branch
from
7dde42e
to
84cd978
Compare
ImageDocumentParser keeps the ImageResource for ImageDocument and passes the associated ImageResourceContent to the HTMLImageElement used for the ImageDocument. This eliminates ImageDocument::CachedImageResourceDeprecated and cleans up ImageDocument<->ImageDocumentParser interaction a bit. The creation of the ImageResource now takes place in the first call to ImageDocumentParser::AppendBytes rather than indirectly via a call to ImageDocument::CachedImage. Set ImageLoader::image_complete_ in the same as for regular image-loads, and start dispatching 'load' (and 'error') events for the <img> element in the image document. This behavior matches Gecko. Bug: 958339 Change-Id: Iacdab89f6894adf70163f0d5300aefc9b2fce4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975921 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#726803}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1975921
branch
from
84cd978
to
2ebe2bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageDocumentParser keeps the ImageResource for ImageDocument and passes
the associated ImageResourceContent to the HTMLImageElement used for the
ImageDocument.
This eliminates ImageDocument::CachedImageResourceDeprecated and cleans
up ImageDocument<->ImageDocumentParser interaction a bit.
The creation of the ImageResource now takes place in the first call to
ImageDocumentParser::AppendBytes rather than indirectly via a call to
ImageDocument::CachedImage.
Set ImageLoader::image_complete_ in the same as for regular image-loads,
and start dispatching 'load' (and 'error') events for the <img> element
in the image document. This behavior matches Gecko.
Bug: 958339
Change-Id: Iacdab89f6894adf70163f0d5300aefc9b2fce4e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975921
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726803}