Replaced some simple assert_object_equals cases. #2092
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/5735 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
I can't figure out how to restore the branch at this point, so please re-push it if you still have it locally in case I don't wind up finding a solution. (I deleted it by mistake.) |
OK, I just pushed it from clone and it looks like this PR is now back into the correct state again |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -35,7 +35,7 @@ | |||
| {test:async_test('regexp'), check:function(e) { assert_equals('' + e.data, '/foo/'); assert_equals(e.data instanceof RegExp, true, 'e.data instanceof RegExp'); }}, | |||
| {test:async_test('self'), check:function(e) { assert_equals(e.data, null); }}, | |||
| {test:async_test('array'), check:function(e) { assert_array_equals(e.data, [undefined, null, false, true, 1, NaN, Infinity, 'foo', null, null]); }}, | |||
| {test:async_test('object'), check:function(e) { assert_object_equals(e.data, {a:undefined, b:null, c:false, d:true, e:1, f:NaN, g:Infinity, h:'foo', k:null, n:null}); }}, | |||
| {test:async_test('object'), check:function(e) { assert_equals(JSON.stringify(e.data), JSON.stringify({a:undefined, b:null, c:false, d:true, e:1, f:NaN, g:Infinity, h:'foo', k:null, n:null})); }}, | |||
There was a problem hiding this comment.
Does JSON.stringify have a defined order?
There was a problem hiding this comment.
Perhaps it's better to just enumerate the stuff we want to assert?
|
@stephenmcgruer here's an open PR in case you missed it in #2033. |
Part of #2033