CacheStorage: Set opaque mode for code cache. #21074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 7, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1988675
branch
4 times, most recently
from
9f0bc43
to
1559c91
Compare
This CL restores code to set the V8 code cache generation opaque mode based on the response tainting. It was previously incorrectly removed in crrev.com/c/1828726. This CL adds a test that verifies scripts loaded from cache_storage are treated as opaque when appropriate. It has been verified to fail without the fixed code. The CL also fixes an incorrect DCHECK that the test triggers. The assumption in the DCHECK was incorrect and should instead be a runtime check. Bug: 1037701 Change-Id: I894b30ad9dac6c3a47e1b5f325ee7906768b57f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988675 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#729327}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1988675
branch
from
1559c91
to
caafccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL restores code to set the V8 code cache generation opaque mode
based on the response tainting. It was previously incorrectly removed
in crrev.com/c/1828726.
This CL adds a test that verifies scripts loaded from cache_storage are
treated as opaque when appropriate. It has been verified to fail
without the fixed code.
The CL also fixes an incorrect DCHECK that the test triggers. The
assumption in the DCHECK was incorrect and should instead be a runtime
check.
Bug: 1037701
Change-Id: I894b30ad9dac6c3a47e1b5f325ee7906768b57f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988675
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729327}