Implement WebXR lighting estimation API #21098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 8, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1965850
branch
5 times, most recently
from
541c4c1
to
874ddcd
Compare
This implements the API outlined in the explainer here: https://github.com/immersive-web/lighting-estimation Initial components of this implementation were done by bialpio@. Bug: 1034135 Change-Id: I98ba7d3e7c166c6ac2254efae4f5b79e4bb95f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965850 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#732270}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1965850
branch
from
874ddcd
to
e54282d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the API outlined in the explainer here:
https://github.com/immersive-web/lighting-estimation
Initial components of this implementation were done by bialpio@.
Bug: 1034135
Change-Id: I98ba7d3e7c166c6ac2254efae4f5b79e4bb95f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965850
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#732270}