[webnfc] NDEFRecordInit#encoding is only applicable for BufferSource data source #21106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 9, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1991972
branch
4 times, most recently
from
3b9364a
to
ce11818
Compare
…data source DOMString data source is always encoded as utf-8. The spec change: w3c/web-nfc#522 BUG=520391 Change-Id: Iec3d923d169f7a61937eda5249a57c6803598678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991972 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#732272}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1991972
branch
from
ce11818
to
92674e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOMString data source is always encoded as utf-8.
The spec change:
w3c/web-nfc#522
BUG=520391
Change-Id: Iec3d923d169f7a61937eda5249a57c6803598678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991972
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#732272}