Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let AES-KW to wrap/unwrap JWK #21149

Closed
wants to merge 2 commits into from
Closed

Don't let AES-KW to wrap/unwrap JWK #21149

wants to merge 2 commits into from

Conversation

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Jan 13, 2020

No description provided.

Jiewen Tan and others added 2 commits May 27, 2017
@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Jan 14, 2020

I have to mark this as non-draft to get TC to run, but will be removing reviewers after wpt-pr-bot adds them. Sorry for the spam.

@stephenmcgruer stephenmcgruer marked this pull request as ready for review Jan 14, 2020
@wpt-pr-bot wpt-pr-bot requested a review from jimsch Jan 14, 2020
@stephenmcgruer stephenmcgruer removed the request for review from jimsch Jan 14, 2020
@jimsch
Copy link
Contributor

jimsch commented Jan 14, 2020

I do not believe that this is a correct modification to the tests. Section 14.3.11 provides a method of converting a JWK to an object which can be encrypted. Why do you believe this is not true?

@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Jan 14, 2020

Sorry @jimsch , I failed to note above that this PR is a straight rebase of #6102, trying to see if an old change can be relanded (or really just what it's state is). The author at that time thought it was necessary, but it is over 1.5 years old now so may well be that the spec has moved on.

@jimsch
Copy link
Contributor

jimsch commented Jan 14, 2020

As I read the spec now, it appears that there is a way to get bytes from the JWK in the specification. I think therefore that this is probably a dead change and should be closed.

@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Jan 14, 2020

Sgtm, left a comment in (and closed) #6102

@stephenmcgruer stephenmcgruer deleted the smcgruer/aes_kw branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.