Portals: Block focus from advancing into portal #21204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1951767
branch
2 times, most recently
from
a2da904
to
46be92c
Compare
Prevents focus from advancing inside a portal frame from the renderer process, and adds an security check in the browser process. Bug: 1030838 Change-Id: I1e82d2163142ba357aa4d7adb4f0b66d0fb5b676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951767 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732478}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1951767
branch
from
46be92c
to
1186446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents focus from advancing inside a portal frame from the renderer
process, and adds an security check in the browser process.
Bug: 1030838
Change-Id: I1e82d2163142ba357aa4d7adb4f0b66d0fb5b676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951767
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732478}