Add tests of the recalculation of 'ch' in pseudo elements #21362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 23, 2020
Length unit 'ch' should be recalculated after loading a web font. This patch is a followup of crrev.com/c/1972815 to ensure that it's also recalculated in pseudo elements. Bug: 441925 Change-Id: Ie62dba854aa9d1beb6b9a734f31760abf1acd040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016198 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#734495}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2016198
branch
from
8e2c35d
to
0083239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Length unit 'ch' should be recalculated after loading a web font. This
patch is a followup of crrev.com/c/1972815 to ensure that it's also
recalculated in pseudo elements.
Bug: 441925
Change-Id: Ie62dba854aa9d1beb6b9a734f31760abf1acd040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016198
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734495}