Fix scroll to text WPT flakiness #21416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 24, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2018099
branch
from
862ef38
to
0621380
Compare
Since stash.py polls until results are available, the tests can time out in a single threaded environment if the test page tries to fetch results before the target page stashes them. This patch moves the polling to stash.js instead, so that the target page is free to stash results. Also adds a window.close() call on the target page after stashing results, otherwise each test case leaves a leftover window which can slow down the test environment. Bug: #20269 Change-Id: Ia2df8f889596e91207aca92f6ecb290c9f96d201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018099 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#735578}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2018099
branch
from
0621380
to
68bb053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since stash.py polls until results are available, the tests can time out
in a single threaded environment if the test page tries to fetch results
before the target page stashes them. This patch moves the polling to
stash.js instead, so that the target page is free to stash results.
Also adds a window.close() call on the target page after stashing
results, otherwise each test case leaves a leftover window which can
slow down the test environment.
Bug: #20269
Change-Id: Ia2df8f889596e91207aca92f6ecb290c9f96d201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018099
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735578}