Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces/webrtc-priority.idl and test #21462

Closed
wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Jan 28, 2020

Closes #21442.

@foolip
Copy link
Member Author

foolip commented Jan 28, 2020

test_tests_affected_idlharness is failing. That's an annoying test to have to update :)

Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo fixing that test.

Looks like no browser currently implements this. Do we know if there is an intention to?

@foolip
Copy link
Member Author

foolip commented Feb 5, 2020

@dontcallmedom do you know what implementor interest is like for webrtc-identity?

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21462 February 5, 2020 22:55 Inactive
@stephenmcgruer
Copy link
Contributor

@dontcallmedom do you know what implementor interest is like for webrtc-identity?

Ping @dontcallmedom and @alvestrand for this question. As of today, I still can't find a priority member in Chrome's RTCDataChannel definition (haven't checked other browsers).

@guest271314
Copy link
Contributor

Is this similar to or based on scheduler.postTask()?

@alvestrand
Copy link
Contributor

There's some interest in completing the plumbing on priority for datachannels.
We already have the plumbing in place for RTCRtpEncodingParameters, which is the other place where priority is surfaced.

As for webrtc-identity, there's been some push, mainly from Cisco and Mozilla, to make that happen, but that has so far (AFAIK) not led to either a standards conformant implementation in Firefox or a product that uses this feature on any platform. It's been a while since I last heard someone mention it as something they wanted to work on.

The attitude at Google on identity has been "let's see Mozilla show that it is possible to implement and serves an useful function - then we'll think about adding it".

@foolip
Copy link
Member Author

foolip commented May 8, 2020

Thanks @alvestrand, that explains why https://wpt.fyi/results/webrtc-priority/idlharness.window.html?label=pr_head&max-count=1&pr=21462 has the tests failing everywhere.

I'm going to close this PR and leave #21442 open, with a reference to revive this if implementer interest materializes.

@foolip foolip closed this May 8, 2020
@foolip foolip deleted the foolip/webrtc-priority branch May 8, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants