Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPT tests for grid-item-auto-margins-alignment #21509

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 30, 2020

This CL adds grid-item-auto-margins-alignment tests
to the WPT project, adapted from browser specific tests.
The corresponding outdated tests are being removed from the
fast/css-grid-layout folder.

Change-Id: Icd1af41c6e6248fc6db53fd9f10bbc4a69f0cf7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027793
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#739835}

Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2027793 branch 2 times, most recently from 0127390 to 0740b78 Jan 30, 2020
This CL adds grid-item-auto-margins-alignment tests
to the WPT project, adapted from browser specific tests.
The corresponding outdated tests are being removed from the
fast/css-grid-layout folder.

Change-Id: Icd1af41c6e6248fc6db53fd9f10bbc4a69f0cf7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027793
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#739835}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2027793 branch from 0740b78 to 336050f Feb 10, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f7f4979 into master Feb 10, 2020
6 of 9 checks passed
6 of 9 checks passed
Azure Pipelines Build #20200210.16 failed
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview failed
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2027793 branch Feb 10, 2020
aslushnikov pushed a commit to aslushnikov/webkit that referenced this pull request Feb 14, 2020
https://bugs.webkit.org/show_bug.cgi?id=207534

Patch by Rossana Monteriso <rmonteriso@igalia.com> on 2020-02-12
Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Add grid-item-auto-margins-alignment tests, checked and adapted to WPT, with their expected.txt files.
Imported to WPT with this PR: web-platform-tests/wpt#21509

* web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-expected.txt:
* web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-lr-expected.txt:
* web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-lr.html:
* web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-rl-expected.txt:
* web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-rl.html:
* web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment.html:

LayoutTests:

Remove grid-item-auto-margins-alignment tests and their expected.txt files. These tests
are being replaced by adapted tests in the corresponding WPT test folder.

* fast/css-grid-layout/grid-item-auto-margins-alignment-expected.txt: Removed.
* fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr-expected.txt: Removed.
* fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl-expected.txt: Removed.
* fast/css-grid-layout/grid-item-auto-margins-alignment.html: Removed.
* fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html: Removed.
* fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@256445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.