Add WPT tests for grid-item-auto-margins-alignment #21509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 30, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2027793
branch
2 times, most recently
from
0127390
to
0740b78
Compare
This CL adds grid-item-auto-margins-alignment tests to the WPT project, adapted from browser specific tests. The corresponding outdated tests are being removed from the fast/css-grid-layout folder. Change-Id: Icd1af41c6e6248fc6db53fd9f10bbc4a69f0cf7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027793 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#739835}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2027793
branch
from
0740b78
to
336050f
Compare
aslushnikov
pushed a commit
to aslushnikov/webkit-old
that referenced
this pull request
Feb 14, 2020
https://bugs.webkit.org/show_bug.cgi?id=207534 Patch by Rossana Monteriso <rmonteriso@igalia.com> on 2020-02-12 Reviewed by Javier Fernandez. LayoutTests/imported/w3c: Add grid-item-auto-margins-alignment tests, checked and adapted to WPT, with their expected.txt files. Imported to WPT with this PR: web-platform-tests/wpt#21509 * web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-expected.txt: * web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-lr-expected.txt: * web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-lr.html: * web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-rl-expected.txt: * web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment-vertical-rl.html: * web-platform-tests/css/css-grid/alignment/grid-item-auto-margins-alignment.html: LayoutTests: Remove grid-item-auto-margins-alignment tests and their expected.txt files. These tests are being replaced by adapted tests in the corresponding WPT test folder. * fast/css-grid-layout/grid-item-auto-margins-alignment-expected.txt: Removed. * fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr-expected.txt: Removed. * fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl-expected.txt: Removed. * fast/css-grid-layout/grid-item-auto-margins-alignment.html: Removed. * fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html: Removed. * fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@256445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds grid-item-auto-margins-alignment tests
to the WPT project, adapted from browser specific tests.
The corresponding outdated tests are being removed from the
fast/css-grid-layout folder.
Change-Id: Icd1af41c6e6248fc6db53fd9f10bbc4a69f0cf7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027793
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#739835}