Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Worker: Add data URL tests for nested dedicated workers" #21801

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 14, 2020

This reverts commit 1d73a2eb29cb7088b4920cf8958b6b3d053b093a.

Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322)

Original change's description:

Worker: Add data URL tests for nested dedicated workers

This CL renames data-url.html to data-url.any.js in order to run the
tests on a dedicated worker. Previously these tests only ran on window.

Bug: n/a
Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741367}

TBR=nhiroki@chromium.org,shimazu@chromium.org

Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: n/a
Bug: 1052322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741417}

This reverts commit 1d73a2eb29cb7088b4920cf8958b6b3d053b093a.

Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322)

Original change's description:
> Worker: Add data URL tests for nested dedicated workers
>
> This CL renames data-url.html to data-url.any.js in order to run the
> tests on a dedicated worker. Previously these tests only ran on window.
>
> Bug: n/a
> Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741367}

TBR=nhiroki@chromium.org,shimazu@chromium.org

Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: n/a
Bug: 1052322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741417}
Copy link
Collaborator

wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a36ca8f into master Feb 14, 2020
9 checks passed
9 checks passed
Azure Pipelines Build #20200214.26 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-1b31144c27 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.