[LayoutNG] Generate first baseline for kInlineBlock baseline algorithm. #21820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 16, 2020
In https://chromium-review.googlesource.com/c/chromium/src/+/1988376 I simplified the logic a little too much. We (occasionally) need the first-baseline of a child inside an inline-block. We need this when we are aligning a list-marker. This modifies the NGBaselineAlgorithmType::kInlineBlock to always produce both the first and last baselines. Bug: 1051181 Change-Id: I4844dfe44d3525a68ee8b8d7f0f50bd995de9367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057344 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741798}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2057344
branch
from
dba3a4c
to
3451bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://chromium-review.googlesource.com/c/chromium/src/+/1988376 I
simplified the logic a little too much.
We (occasionally) need the first-baseline of a child inside an
inline-block. We need this when we are aligning a list-marker.
This modifies the NGBaselineAlgorithmType::kInlineBlock to always
produce both the first and last baselines.
Bug: 1051181
Change-Id: I4844dfe44d3525a68ee8b8d7f0f50bd995de9367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057344
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741798}