Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 grammar-spelling-* tests and active-selection-005-manual test #21862

Closed

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Feb 18, 2020

2 tests testing a word with both a spelling error and a grammar error:
grammar-spelling-errors-001.html
grammar-spelling-errors-001-ref.html
grammar-spelling-errors-002.html
grammar-spelling-errors-002-ref.html

1 test testing ::selection highlight and
styling of css property caret-color:
active-selection-005-manual.html

@TalbotG TalbotG assigned fantasai and unassigned plinss May 5, 2020
@TalbotG TalbotG requested review from fantasai and removed request for plinss June 15, 2020 22:56
Copy link
Contributor

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments:

  • Afaict it's not possible to have a visible caret in the middle of a highlighted word. So I'm not sure the active-selection-005 case is actually testable. We might need to skip the ::selection case, and only test caret-color for spelling and grammar errors.
  • Afaict, the contenteditable element needs to be focused in order for the spelling error to be visible in Firefox and Chrome. We should do that with JS, and adjust the instructions to clarify that the contenteditable needs to be active for the test to work.
  • Both 001 and 002 test that both the color and background of ::grammar-error is overridden by ::spelling-error. But we don't have a test for a combined result. If in 001 you move 'color: green' from ::spelling-error to ::grammar-error (and leave it unspecified for ::spelling-error), and in 002 you move 'background: yellow' from ::spelling-error to ::grammar-error (and leave it unspecified for ::spelling-error), then the tests will check that both ::spelling-error and ::grammar-error are correctly applied, and that ::spelling-error overrides ::grammar-error where there's a conflict (but not otherwise).

@TalbotG
Copy link
Contributor Author

TalbotG commented Aug 22, 2020

The initial commit in this PR was done before July 7th. Therefore, I must close this PR and create a new one (in a few min: ) ... which will have the improved grammar-spelling-errors-001.html and grammar-spelling-errors-002.html tests with their also-improved respective references.

active-selection-005-manual.html
will be replaced by
spelling-error-004-manual.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants