WPT: Fix bogus use of assert_object_equals() #21911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 20, 2020
This test was converted from js-test.js to testharness.js in https://crrev.com/625734 and incorrectly used assert_object_equals. * assert_object_equals() will assert that enumerable properties are the same. Since `new Number(42)` doesn't have any own properties, nothing useful was actually being asserted! * assert_equals() is sufficient for an object identity test. * The original test used `new Number(42)` to mint an object that would serialize as something distinct. This isn't necessary with testharness.js assertions - using {} is good enough. assert_object_equals() has lots of non-intuitive behavior, see #2033 for more. Change-Id: I202f27c228c7ec65407d9eae724af21181e6e684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067565 Auto-Submit: Joshua Bell <jsbell@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#743523}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2067565
branch
from
c581e23
to
79ad2b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was converted from js-test.js to testharness.js in
https://crrev.com/625734 and incorrectly used assert_object_equals.
the same. Since
new Number(42)doesn't have any own properties,nothing useful was actually being asserted!
new Number(42)to mint an object that wouldserialize as something distinct. This isn't necessary with
testharness.js assertions - using {} is good enough.
assert_object_equals() has lots of non-intuitive behavior, see
#2033 for more.
Change-Id: I202f27c228c7ec65407d9eae724af21181e6e684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067565
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743523}