WPT: Fix incorrect use of assert_object_equals #21921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 21, 2020
This test was using assert_object_equals() to verify object identity, similar to #20844 which (a) wasn't validating identity and (2) failing in all browsers because that assert function is subtle/weird. Switch to just assert_equals() and remove expectation file. General issue: #2033 Change-Id: I9ee44d251b53955bb9101810142aac8e89a8b5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068248 Commit-Queue: Joshua Bell <jsbell@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#743639}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2068248
branch
from
457ffb5
to
1b2c0a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was using assert_object_equals() to verify object identity,
similar to #20844
which (a) wasn't validating identity and (2) failing in all browsers
because that assert function is subtle/weird. Switch to just
assert_equals() and remove expectation file.
General issue: #2033
Change-Id: I9ee44d251b53955bb9101810142aac8e89a8b5be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068248
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743639}