-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WPT: Upstream and add some transaction scheduling tests #22027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
f42e3e2
to
0ad60ee
Compare
In service of w3c/IndexedDB#253 move some transaction scheduling tests from Blink to WPT. This involved converting them from js-test.js to testharness.js, but the overall logic of each test was retained. This also adds one new test which verifies the change described in w3c/IndexedDB#319 - all browsers implicitly block R-O transactions behind overlapping R/W transactions. Change-Id: I596aaa75b79bf3bf3e17a2553abb4e11329d59ab Bug: 921193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081237 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#746553}
0ad60ee
to
dd51f13
Compare
wpt-firefox-nightly-stability /IndexedDB/transaction-lifetime-blocked.htm /IndexedDB/transaction-lifetime.htm Pre-existing? |
I can repro the failures of those tests in FF locally by reloading the files a few times. |
FWIW, both of those tests will fail if another test leaves a database named 'db' with a version higher than 3; it doesn't proactively delete the database before trying to use it. Tests that use 'db' as a name look like they all have A good fix would be to use a unique database name per test, as is done in most places. |
Putting up a Chrome CL to address that flakiness. https://chromium-review.googlesource.com/c/chromium/src/+/2086452/ |
Thanks for proactively looking at this! Since there's a fix in flight, I'm going to admin-merge this. |
In service of w3c/IndexedDB#253 move some
transaction scheduling tests from Blink to WPT.
This involved converting them from js-test.js to testharness.js, but
the overall logic of each test was retained.
This also adds one new test which verifies the change described
in w3c/IndexedDB#319 - all browsers implicitly
block R-O transactions behind overlapping R/W transactions.
Change-Id: I596aaa75b79bf3bf3e17a2553abb4e11329d59ab
Bug: 921193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081237
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746553}